Repository navigation
feat(oauth): storefront scopes for Continue with Fleetbase - #163
Merged
Merged
Conversation
storefront:read lists the token's organization's stores and networks with their public keys; storefront:app-key creates (or returns) one named API key per app for its Storefront app build; storefront:review-access covers the storefront-store and storefront-network types on core's review-access endpoint.
This was referenced Oct 25, 2026
roncodes
added a commit
that referenced
this pull request
Oct 27, 2026
…review guards The OAuth StorefrontController (#163) had no tests. Cover the store and network listing (scoped to the token's organization) and the app key (created once, reused after; expired, test and other-company keys are never returned). Also cover the App Review notice in new-order SMS and mail, and a customer whose account can't be loaded. OAuthScopes no longer checks for core's OAuth provider: storefront requires core-api ^1.6.74, which always has it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Storefront scopes for Continue with Fleetbase, the OAuth provider in fleetbase/core-api#324. With them, AppHelm can connect a Cloud customer's storefront without the customer pasting any keys.
storefront:readGET /storefront/oauth/v1/storefrontsstore_/network_keys, name, currency, contact, logo,online,pickup_enabledandreview_access_type. Nothing about customers, orders or paymentsstorefront:app-keyPOST /storefront/oauth/v1/app-keyFLEETBASE_KEY. The key is listed under Developers → API Keys, where the organization can revoke it. Keys the app didn't create are never returnedstorefront:review-access/oauth/v1/review-access/storefront-store|storefront-network/{id}RELEASE.mdunder v0.4.30.Base:
release/v0.4.30(#162). Needs core-api 1.6.74 with #324.Not run: Storefront's unit tests. This checkout's
server_vendorhas an older core-api without the OAuth or App Review classes. The token checks these endpoints rely on are tested in core-api#324. These two endpoints still need an end-to-end check on a running stack.