support for Node.js 12 - #64
Merged
Merged
Conversation
lamweili
suggested changes
Feb 15, 2020
| this._headers = this.response._headers = this.response._headers || {}; | ||
|
|
||
| // Patch to node core | ||
| this.response._headerNames = this.response._headerNames || {}; |
There was a problem hiding this comment.
Shouldn't this not be in the catch, but in another try-catch?
// Patch to node core
try {
this.response._headerNames = this.response.getHeaderNames() || {};
} catch (err) {
this.response._headerNames = this.response._headerNames || {};
}
There was a problem hiding this comment.
It has been commented in PR #77 that there is no need for this suggestion.
@darrendatbui has did some testing and the original committed code works.
I rest my case.
|
When can we expect this patch to be published? |
|
@Xmader Mind making the suggested changes? |
|
ping? |
Closed
|
This fixes issue #68. This will supersede PR #71 and PR #77; these 2 PRs can be closed. Ping @indexzero @jcrugzz |
lamweili
approved these changes
Jan 15, 2024
Contributor
|
Appreciate everyone trying to keep this code alive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/api/deprecations.html#deprecations_dep0066_outgoingmessage_prototype_headers_outgoingmessage_prototype_headernames