Open
Conversation
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
We have long run with the ipc, network, and pid sandboxes disabled in the belief that these did not work in a container even if it was privileged. I suspect it really did work back then, but it certainly does work now regardless. update_sdk_container_image uses Portage in an unprivileged docker build environment, so it is still necessary to disable these here. However, this can be done more easily through the environment, and the regular sandbox should work fine. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This generally shouldn't happen, given that we mostly only keep one instance of a bin package, but just in case. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
update_sdk_container_image failed to update baselayout because it touched /sys, which is not allowed in an unprivileged docker build environment. dumb-tmpfiles-proc.sh does not touch existing directories, but it was modifying the staging directory rather than the live filesystem, causing Portage to record /sys in the package's CONTENTS and then make changes to it when merging. We only need to create the directories in pkg_preinst because the other file types are already created in src_install. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rm_masked_debug_filesPortage hook from complaining when it does nothing.docker buildoutput inupdate_sdk_container_image.build_imagefrom installnig packages to the image with bad USE flags.update_sdk_container_image.How to use
Try running
update_sdk_container_imagewith a baselayout bump.Testing done
A two-phase SDK build in Jenkins has succeeded. I also did the above.
changelog/directory (user-facing change, bug fix, security fix, update) -- N/A/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.