feat(env): skip .kube in default grep ignore (port #51 to main)#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports the
.kubegrep-ignore from PR #51 (feat(env): grep-ignore .kube) ontomain.PR #51 merged into
feat/ai-sreonly and never reachedmain, so this kubeconfig-token hygiene was missing from the release trunk. This is the only content that lived onfeat/ai-sreand not onmain; landing it here lets us retirefeat/ai-sre.Change
environment/environment.go: add.kubetodefaultGrepIgnoreDirsso the Go grep fallback skips read-only kubeconfigs placed by/initand keeps their tokens out of grep output.environment/environment_test.go: assert.kubeis ignored.Cherry-pick of
875aa6a(clean, +5 lines).Verify
go build ./environment/— OKgo test ./environment/ -run TestEnvironment_Grep_DefaultIgnore— PASS