Repository navigation
Say sign-in is limited when lockout is left out - #173
Merged
Merged
Conversation
The service release this plugin ships with gives an Account without lockout Rails' own sign-in rate limit (firstdraft/firstdraft#1147), so the Skill's Accounts text no longer says failed sign-ins are unlimited. It points at DEPLOY.md's Failed sign-ins section, because a classroom on one network shares the per-IP limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service release that plugin 0.8.16 ships with gives an Account without
lockoutRails' own sign-in limit (10 attempts per IP address every three minutes). The Skill's Accounts text ininterview.mdandfoundation-plan-023.mdsaid failed sign-ins were not limited; it now describes the limit and points atDEPLOY.md's Failed sign-ins section for the shared-network case.sh script/check --cli-rootpasses.Docs: updated the Accounts text in
interview.mdandfoundation-plan-023.mdand the 0.8.16 CHANGELOG entry.Review: Codex (codex-review, high effort), approve, 0 findings.