Repository navigation
Point one-tap records at the Guide and return Unlike to the parent - #126
Closed
raghubetina wants to merge 1 commit into
Closed
raghubetina wants to merge 1 commit into
raghubetina wants to merge 1 commit into
Conversation
firstdraft/firstdraft#1005 ships the one-tap Compiler change tonight: a no-input associated create renders as a button on the parent page and returns there, and a uniqueness rule plus an owner-authorized destroy turn the button into a Like/Unlike toggle. The destroy keeps its own destination, so Unlike returns to the parent only when the Plan authors destroy.return_to through the parent Reference; otherwise it goes to the ordinary delete destination, which is Home for a Like with no index. The Skill's Like example authored no such return, so an agent copying it would send every Unlike to Home. The Like fragment is now a byte-for-byte copy of the Guide's No-input records example, including destroy.return_to through like.post, and the modeling cue and example link the public Guide anchor. The caveat that a deployed Compiler may still show a separate Create page is removed because publication follows the deploy. The associated-create return and entry-point passages name the no-input exception so they no longer contradict it. The same pull request sends guests who request a protected page to sign-in and returns them afterwards; the signed-in gate example now says so. The one-tap-like-record eval expects the authored return; it was not run. The Like fragment passes the schema test in test/repository.test.mjs. The tarball digest is left for the 0.8.4 release branch, which repacks it.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
firstdraft/firstdraft#1005 makes the Compiler emit a one-tap button for a no-input associated create, and a Like/Unlike toggle when the record also has a uniqueness rule over the parent and the signed-in Account References and an owner-authorized destroy. A create returns to the parent page. The destroy keeps its own destination, so Unlike returns to the parent only when the Plan authors
destroy.return_tothrough the parent Reference (for examplelike.post); otherwise it goes to the ordinary delete destination, which is Home for a Like with no index. The Skill's Like example authored no such return, and its "deployed Compiler may still show a separate Create page" caveat stops being true once #1005 deploys.This change:
references/examples.mda byte-for-byte copy of the public Guide's No-input records example (singlelike.manage_ownmanagePolicy,destroy.return_tothroughlike.post), and points the modeling-guide cue and the example at that anchor;references/modeling-guide.mdandreferences/foundation-plan-023.md;one-tap-like-recordeval expectation fordestroy.return_tothrough Like's Recipe Association.SKILL.md,
references/interview.md, and the modeling guide's implementation-notes section are untouched, so this stays clear ofskill-fit-check. The commit merges cleanly ontoplugin-0-8-4.Release: fold this into the 0.8.4 release branch
plugin-0-8-4; do not release it on its own. It must publish only after firstdraft/firstdraft#1005 is merged and deployed and Pages republishes the Guide anchor. Version, CHANGELOG label, andplugin_source.tarball_sha256are left for that branch, so hosted CI's pinned-CLI package step is expected to fail on the digest here (packed with pinned CLI 2f4bc93, this branch alone gives1b0c167991c577925f6cea573f23d7633ab7f570a81255ac25ee3cbc76024966; the release branch repacks it). Localnpm ci --ignore-scripts && npm audit && sh script/checkpasses (85 tests, 0 vulnerabilities), including the schema test that validates the copied Like fragment.Proposed CHANGELOG bullet for the 0.8.4 entry:
Docs: updated the Skill's modeling guide, examples, and Foundation Plan reference for one-tap records and guest sign-in; the CHANGELOG bullet above goes into the 0.8.4 release branch.