Repository navigation
Key first-run failures on Behavior to write - #84
Merged
Merged
Conversation
The next First Draft deploy keeps a polymorphic Reference's storage when a target cannot carry the authored deletion outcome. Such a target refuses its own deletion while a record references it, and a cascade or nullification it leaves out fails its deletion spec with RecordNotDestroyed. The README's Behavior to write lists that outcome, and the generated AGENTS.md now calls any spec that fails through behavior on that list work to do. The workshop notes called only a NotImplementedError work to do, so an agent would have reported a left-out deletion as a First Draft defect. They now key the first run on the Behavior to write list and name both failure shapes, as the app's AGENTS.md does. Before the deploy no README lists a deletion outcome, so the rule holds on both sides of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the next First Draft deploy, a polymorphic Reference keeps its storage when a target cannot carry the authored deletion outcome. That target refuses its own deletion in a private
before_destroywhile a record references it, and a cascade or nullification it leaves out fails its deletion spec withActiveRecord::RecordNotDestroyed. The generated README's Behavior to write lists that outcome, and the generatedAGENTS.mdnow says:The workshop notes (from #80) called only a
NotImplementedErrorwork to do, so an agent would have reported a left-out deletion as a First Draft defect.This changes only the first bullet of Setup and specs in
.devcontainer/workshop/app-instructions.md: a spec that fails through behavior the README's Behavior to write lists is work to do, and the bullet names both failure shapes. Everything else in the file is unchanged. Before the deploy no README lists a deletion outcome, so the rule holds on both sides of it.Verified. The wording follows the
AGENTS.mdtemplate at servicemaina55d79bb. A Compile of the service's multi-target smoke Plan on that commit produced a README whose Behavior to write lists a Remark cascade, and its specs failed only there, withRecordNotDestroyed.Not run: a Codespace, and an agent reading the notes.
Not for merging until the owner approves: merging changes what new workshop Codespaces get.
Docs: updated
.devcontainer/workshop/app-instructions.md(Setup and specs).Review: Codex (codex-review 0.8.0, max effort), session c5411aaa-17e4-461b-903e-fc38b36aa4a6, approve.