Repository navigation
Check that Neon key saving rejects org keys - #18
Merged
Merged
Conversation
The Board's neon-key.sh save now runs auth.sh check neon, which asks neonctl profile list for the saved credential and then neonctl me. neonctl 8 saves an organization or project key, but me answers "not allowed for organization API keys", so attendees who made one failed later with a vague message. The fake neonctl now keeps the saved key and answers both commands, so the check covers an organization key that save rejects and keeps the form for, then a personal key that saves and passes.
The Board's check_neon and neon-key.sh save now ask neonctl which credential it will use and reject organization and project keys, which the updated workshop helper check exercises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fake
neonctlnow answersprofile list --output jsonandme --output jsonfrom the key it saved, so the workshop helper check covers an organization key (save prints INVALID, keeps the form, check names the wrong kind) and a personal key (SAVED, check passes). Qualifies firstdraft/drawing-board#78 at a87160456bffdd6e76551ff23cff492e6d556159.