Add dark mode versions of the fullscreen icons#5972
Merged
canova merged 2 commits intofirefox-devtools:mainfrom Apr 27, 2026
Merged
Add dark mode versions of the fullscreen icons#5972canova merged 2 commits intofirefox-devtools:mainfrom
canova merged 2 commits intofirefox-devtools:mainfrom
Conversation
These svg icons were hardcoded to black color, which made them very difficult to see in the dark mode. This commit adds dark mode equivalents of these icons to make sure that they are visible there as well.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5972 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 323 323
Lines 32262 32262
Branches 8895 8810 -85
=======================================
Hits 27532 27532
Misses 4298 4298
Partials 432 432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Would be nice to see a deploy preview profile :) |
Member
Author
fatadel
approved these changes
Apr 27, 2026
Contributor
fatadel
left a comment
There was a problem hiding this comment.
I wonder why fullscreen and fullscreen-exit are of different sizes but that does not seem to be introduced here... Thanks for the PR!
Member
Author
|
Thanks! Yeah, that's weird but they are directly from: https://acorn.firefox.com/latest/desktop/styles/iconography-OJ7DtlvA It looks like the upstream's svg file is incorrect (but not a big deal). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5970.
These svg icons were hardcoded to black color, which made them very difficult to see in the dark mode. This commit adds dark mode equivalents of these icons to make sure that they are visible there as well.
Deploy preview