Skip to content

Add dark mode versions of the fullscreen icons#5972

Merged
canova merged 2 commits intofirefox-devtools:mainfrom
canova:fullscreen-dark
Apr 27, 2026
Merged

Add dark mode versions of the fullscreen icons#5972
canova merged 2 commits intofirefox-devtools:mainfrom
canova:fullscreen-dark

Conversation

@canova
Copy link
Copy Markdown
Member

@canova canova commented Apr 27, 2026

Fixes #5970.

These svg icons were hardcoded to black color, which made them very difficult to see in the dark mode. This commit adds dark mode equivalents of these icons to make sure that they are visible there as well.

Deploy preview

These svg icons were hardcoded to black color, which made them very
difficult to see in the dark mode. This commit adds dark mode
equivalents of these icons to make sure that they are visible there as
well.
@canova canova requested a review from fatadel April 27, 2026 08:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.33%. Comparing base (c155fdf) to head (920e7c9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5972   +/-   ##
=======================================
  Coverage   85.33%   85.33%           
=======================================
  Files         323      323           
  Lines       32262    32262           
  Branches     8895     8810   -85     
=======================================
  Hits        27532    27532           
  Misses       4298     4298           
  Partials      432      432           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fatadel
Copy link
Copy Markdown
Contributor

fatadel commented Apr 27, 2026

Would be nice to see a deploy preview profile :)

@canova
Copy link
Copy Markdown
Member Author

canova commented Apr 27, 2026

Here it is

Copy link
Copy Markdown
Contributor

@fatadel fatadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why fullscreen and fullscreen-exit are of different sizes but that does not seem to be introduced here... Thanks for the PR!

@canova
Copy link
Copy Markdown
Member Author

canova commented Apr 27, 2026

Thanks! Yeah, that's weird but they are directly from: https://acorn.firefox.com/latest/desktop/styles/iconography-OJ7DtlvA It looks like the upstream's svg file is incorrect (but not a big deal).

@canova canova enabled auto-merge (squash) April 27, 2026 10:21
@canova canova merged commit 423727b into firefox-devtools:main Apr 27, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fullscreen button isn't legible in dark mode

2 participants