Add "Include idle samples" toggle to the call tree settings#5968
Add "Include idle samples" toggle to the call tree settings#5968canova merged 2 commits intofirefox-devtools:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5968 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 323 323
Lines 32214 32262 +48
Branches 8871 8895 +24
=======================================
+ Hits 27490 27532 +42
- Misses 4293 4298 +5
- Partials 431 432 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The derived |
|
Ah I completely forgot that we have the category in the derived samples table now! Moved the idle samples filtering to after the transforms in the timeline. But as we discussed in Matrix, I think it's better to do it before the implementation filter step, so I moved it in between transform and implementation filter steps. Thanks! |
Adds a checkbox next to "Invert call stack" in the call tree, flame graph, and stack chart settings. It is on by default, and when unchecked, samples whose leaf frame is in the Idle category are hidden from the call tree and related views by nulling out their sample.stack entry. The checkbox is only rendered when the profile actually has an "Idle" category. Implemented as a new step in the per-thread filter pipeline, sitting between the transforms and the implementation filter. Since we use the category column that belongs to the derived samples table, we don't need to worry about transforms changing the stack table.
Ideally they should be localized, but apparently they weren't. So let's keep it like this for now, and we can localize these as a follow-up.
This is the approach we wanted to go with instead of #5943, also discussed there. This PR adds a new checkbox that's called "Include idle samples" to the settings of the call tree/flame graph/stack chart.
It's visible only when we have an Idle category. It's checked by default in the web view, but can be unchecked to hide the idle samples. It will be unchecked by default in the profiler-cli though, as we think it's more important to be concise there. But it can be toggled there as well.
Here's a deploy preview