Add an --insert-stack-labels modification to the profiler-edit tool#5966
Draft
mstange wants to merge 2 commits intofirefox-devtools:mainfrom
Draft
Add an --insert-stack-labels modification to the profiler-edit tool#5966mstange wants to merge 2 commits intofirefox-devtools:mainfrom
mstange wants to merge 2 commits intofirefox-devtools:mainfrom
Conversation
Before:
```
node dist/symbolicator-cli.js \
--input samply-profile.json \
--output profile-symbolicated.json \
--server http://localhost:3000
```
After:
```
node node-tools-dist/profiler-edit.js \
-i samply-profile.json \
-o profile-symbolicated.json \
--symbolicate-with-server http://localhost:3000
```
The new tool also accepts a URL or profile storage hash as input, and can
write gzip-compressed output:
```
node node-tools-dist/profiler-edit.js \
--from-hash w1spyw917hg... \
-o out.json.gz \
--symbolicate-with-server http://localhost:8001/abcdef/
```
The reason for this change is that I want to add further ways to
modify profiles in the future (such as an `--insert-label-frames`
argument) and it doesn't really make sense to have a separate tool
for each modification.
This commit also moves the script file to /src/node-tools/ and the output to /node-tools-dist/.
I'm planning to add more scripts of this type in the future.
This command takes a .toml file and adds label frames to a profile based on matching function names. We use this for profiles from samply, to insert labels for DOM calls etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #5965.
This lets us create profiles like https://share.firefox.dev/4mPPTgr with DOM label frames that show up in the JS-only view, for profiles from samply, based on function name matching. The matchers are declared in a toml file that is passed to the script.