[Deploy preview] Add a function list#5233
Draft
mstange wants to merge 22 commits intofirefox-devtools:mainfrom
Draft
[Deploy preview] Add a function list#5233mstange wants to merge 22 commits intofirefox-devtools:mainfrom
mstange wants to merge 22 commits intofirefox-devtools:mainfrom
Conversation
mstange
force-pushed
the
function-list
branch
from
48f5a60 to
c8c16b9
Compare
mstange
force-pushed
the
function-list
branch
from
c8c16b9 to
4d44cf7
Compare
mstange
force-pushed
the
function-list
branch
4 times, most recently
from
25bc285 to
af75e01
Compare
mstange
force-pushed
the
function-list
branch
2 times, most recently
from
26f8559 to
abde12b
Compare
lint fix
…ings
- Fix wrong tab slug ('calltree' → 'function-list') in _onEnterOrDoubleClick
for SelfWing, UpperWingFlameGraph, LowerWing, and UpperWing so that
double-clicking a call node opens the bottom box for the correct tab
- Add a contextMenuId prop to FlameGraph (defaulting to 'CallNodeContextMenu')
so wings can specify a different context menu
- Wire up FunctionListContextMenu for UpperWingFlameGraph and SelfWing:
right-clicking now dispatches changeRightClickedFunctionIndex so the
FunctionListContextMenu (already rendered in Details) can respond
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy preview
WIP implementing the approach outlined in #15 (comment)