This repository was archived by the owner on Sep 21, 2021. It is now read-only.
Only render the SplitBox draggable when nothing is collapsed.#1064
Open
lijunle wants to merge 1 commit intofirefox-devtools:masterfrom
Open
Only render the SplitBox draggable when nothing is collapsed.#1064lijunle wants to merge 1 commit intofirefox-devtools:masterfrom
lijunle wants to merge 1 commit intofirefox-devtools:masterfrom
Conversation
Member
|
Thanks for the PR and raising the issue! @jasonLaster the fix makes sense I think could you review? |
Contributor
|
Thanks. I'll take a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue:
The debugger is showing scrollbar when collapse the panes.
Besides, currently, when the pane is collapsed, hover on the edge (dragger), the cursor is still showing as "draggable", which is confusing.
Summary of Changes
Test Plan
I FAILED TO RUN ANY TEST. THE DEV IS VERY NOT FRIENDLY. 😞
Screenshots/Videos (OPTIONAL)