Add TAO/NLS RieszMapPC preconditioner test - #5268
Open
bj-chang wants to merge 4 commits into
Open
Conversation
| "pkgconfig", | ||
| "progress", | ||
| "pyadjoint-ad>=2026.4.0", | ||
| "pyadjoint-ad @ git+https://github.com/bj-chang/pyadjoint.git@riesz-map-pc", |
Member
There was a problem hiding this comment.
Suggested change
| "pyadjoint-ad @ git+https://github.com/bj-chang/pyadjoint.git@riesz-map-pc", | |
| "pyadjoint-ad>=2026.4.0", |
dham
previously approved these changes
Jul 21, 2026
bj-chang
force-pushed
the
riesz-map-pc-test-release
branch
from
July 24, 2026 11:28
715700e to
dd8d0cd
Compare
dham
reviewed
Jul 28, 2026
dham
enabled auto-merge (squash)
July 28, 2026 12:44
dham
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test for RieszMapPC, the preconditioner added in dolfin-adjoint/pyadjoint#262. It runs a small optimisation problem in firedrake using that preconditioner, and checks two things: that the preconditioner is actually being used, and that the optimiser still finds the right answer.