feat: add JSON schema for .firebaserc - #11164
Open
richieforeman wants to merge 1 commit into
Open
richieforeman wants to merge 1 commit into
richieforeman wants to merge 1 commit into
Conversation
### Description Adds a JSON schema definition (`schema/firebaserc.json`) for the Firebase Runtime Configuration (`.firebaserc`) file. The schema covers `projects`, `targets` (hosting, storage, database, firestore), `etags`, and legacy `dataconnectEmulatorConfig`. ### Scenarios Tested - Validated against existing `.firebaserc` files in the repository using Ajv. - Validated against full multi-target configuration example. - Checked Prettier code formatting. ### Sample Commands npx prettier --check schema/firebaserc.json
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a JSON schema for the Firebase Runtime Configuration file (.firebaserc) under schema/firebaserc.json. Feedback on the schema suggests setting "additionalProperties": true at the root level instead of false to prevent validation failures on .firebaserc files containing custom or arbitrary properties, which are preserved by the Firebase CLI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11164 +/- ##
=======================================
Coverage ? 60.88%
=======================================
Files ? 651
Lines ? 43805
Branches ? 9011
=======================================
Hits ? 26669
Misses ? 14897
Partials ? 2239 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a JSON schema definition (
schema/firebaserc.json) for the Firebase Runtime Configuration (.firebaserc) file. The schema coversprojects,targets(hosting, storage, database, firestore),etags, and legacydataconnectEmulatorConfig.Scenarios Tested
.firebasercfiles in the repository using Ajv.