Conversation
There was a problem hiding this comment.
Code Review
This pull request improves error handling by surfacing underlying API errors instead of masking them with generic messages. Specifically, in apiv2.ts, non-JSON error responses are handled gracefully by retaining the raw payload when the status is 400 or above. In src/apphosting/secrets/index.ts, unexpected errors during secret loading now include the original error message. The reviewer suggested propagating the original HTTP status code when wrapping the unexpected error in FirebaseError within upsertSecret to prevent it from defaulting to 500.
…rebase-tools into surface-underlying-api-errors
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11133 +/- ##
=======================================
Coverage ? 60.88%
=======================================
Files ? 651
Lines ? 43808
Branches ? 9012
=======================================
Hits ? 26674
Misses ? 14894
Partials ? 2240 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…e-underlying-api-errors
Description
When the user tries to create a secret, they might get a billing error. This change just surfaces that error and its message more clearly.
Scenarios Tested
Sample Commands