fix(functions): honor non-string defaults in params select prompts

[Ishkirat-Singh]

Description

promptSelect stringifies every choice value (option.value.toString()) but passed the resolved default to the select prompt unchanged. A boolean or integer default therefore never matched a choice, and inquirer fell back to preselecting the first option. In non-interactive mode the same raw default was handed straight to the converter, where isTruthyInput calls .toLowerCase() on it.

This stringifies the default the same way the choices are, so defineBoolean/defineInt params with a select input preselect their declared default. promptSelectMultiple was checked as well: its values are already strings (T extends string), so it is not affected by this particular mismatch.

Fixes #11053

Scenarios Tested

• Added unit tests in src/deploy/functions/params.spec.ts covering a boolean select default (false) and an int select default (2), asserting the default passed to the prompt and the resolved ParamValue.
• npx mocha src/deploy/functions/params.spec.ts: 20 passing. Both new tests fail against main without the fix.

Sample Commands

N/A — the change is in the interactive firebase deploy --only functions param prompt.

[gemini-code-assist]

Code Review

This pull request fixes an issue where boolean and integer defaults in select prompts for function parameters were not honored, resulting in the first option being preselected. This is resolved by stringifying the resolvedDefault value in promptSelect so it matches the stringified choice values. Additionally, unit tests have been added to verify this behavior for both boolean and integer defaults, and the changelog has been updated. I have no feedback to provide.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@6a1d5c3). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11059   +/-   ##
=======================================
  Coverage        ?   60.91%           
=======================================
  Files           ?      651           
  Lines           ?    43805           
  Branches        ?     9011           
=======================================
  Hits            ?    26685           
  Misses          ?    14878           
  Partials        ?     2242           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[IzaakGough]

Lgtm! Nice fix. Just needs a conflict in the changelog resolving

[Ishkirat-Singh]

Thanks! Rebased onto main and resolved the CHANGELOG conflict (the release reset the file), and updated the tests for the new resolveParams options object. Should be good to merge.

[Ishkirat-Singh]

@IzaakGough rebased onto main again (it had fallen behind by two commits), no conflicts this time. Ready to merge whenever you get a moment.

[ajperel]

@Ishkirat-Singh - I just merged a significant change to parameter prompting for functions (#11086). It'd be good to update to latest and make sure this and #11062 play nicely with that change. But these seem like good fixes to land. Thank you for the contributions.

[Ishkirat-Singh]

Thanks @ajperel — updated to latest, and I checked both against #11086.

Both fixes are still needed after your rewrite, and both still apply cleanly:

• This PR (fix(functions): honor non-string defaults in params select prompts #11059): promptSelect still passes default: resolvedDefault as string while each choice's value is option.value.toString(), so a boolean or integer default never matches and the first option stays preselected. Now stringifies the default.
• fix(functions): preselect list param defaults in multi-select prompts #11062: promptSelectMultiple still hardcodes checked: false on every choice, so list defaults are never preselected. Now derives checked from the resolved default, and leaves default in place since that is what non-interactive mode reads.

params.spec.ts passes on both branches (25 and 24 respectively, including the cases you added). Nothing else in either diff touches the code you changed.

[ajperel]

I agree this is a good change and just need to fix CHANGELOG

[ajperel]

I think at this point we could make a larger, better change where we don't stringify the values or defaults and get rid of the converters. But I'm not 100% confident without trying it and this smaller change does work, fixes a bug, and I appreciate the contribution.