Skip to content

fix(auth): translate every baselined string and retire the :auth lint baseline - #2523

Draft
demolaf wants to merge 9 commits into
pre-GAfrom
auth/source-baselined-translations
Draft

demolaf wants to merge 9 commits into
pre-GAfrom
auth/source-baselined-translations

Conversation

@demolaf

@demolaf demolaf commented Sep 21, 2026

Copy link
Copy Markdown
Member

Translates the 43 MissingTranslation strings held in auth/lint-baseline.xml across all 84 locale folders, then deletes the baseline and its baseline = line. No module in the repo declares a baseline any more, and ./gradlew lintAll is green without it.

Changes

  • 42 were untranslated UI copy. Nothing was authored cold: each locale's own already-translated vocabulary set the register, so the fui_loading_* strings take their progressive form from fui_progress_dialog_signing_in rather than a guess.
  • The 43rd was never translation debt. fui_sms_terms_of_service_and_privacy_policy_extended was translated everywhere by "Translations for 4.0"; feat: Error Recovery & Dialog #2225 deleted one line from values-ko alone, restored here verbatim.
  • Four tools:ignore="UntranslatedResource" sites, all Account: %1$s in languages where "account" is the word, each carrying its reason.
  • Two OKF lines drop a baseline count that had already drifted from 180 to 43, and the values/strings.xml override comment moves below fui_error_user_disabled, which is live translatable copy rather than one of the empty hooks it describes.

Verified across 43 strings and 84 folders: no missing entries, no malformed XML, no placeholder drift, and no unsuppressed value identical to base English outside the seven values-en-r* folders the check skips.


Maintainer note: Fixes internal CPRN-483

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various resource files to include new strings for re-authentication, MFA management, and profile completion. The reviewer identified that the Bengali translation file (values-bn/strings.xml) contains Hindi (Devanagari) text instead of the correct Bengali translations. I have kept these comments as they point out a critical localization issue that needs to be addressed.

Comment thread auth/src/main/res/values-bn/strings.xml
Comment thread auth/src/main/res/values-bn/strings.xml
Comment thread auth/src/main/res/values-bn/strings.xml
@demolaf
demolaf marked this pull request as ready for review September 21, 2026 15:55
@demolaf
demolaf marked this pull request as draft September 21, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant