Conversation
…ery (#2497) * fix(auth): keep the session id when the continue URL already has a query * fix(auth): don't read a literal ? in a query value as an open query * fix(auth): percent-encode continue URL params by building through Uri * test(auth): pin the encoded form of a continue URL param value
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors ContinueUrlBuilder to use android.net.Uri instead of manual string manipulation for appending query parameters. This change ensures that parameters are properly percent-encoded and correctly appended regardless of whether the incoming URL already contains a query string or a fragment. Additionally, comprehensive unit tests have been added in ContinueUrlBuilderTest and EmailLinkParserTest to verify these behaviors and ensure robust parsing. There are no review comments, and I have no additional feedback to provide.
…2508) * fix(auth): build auth exceptions with the configured string provider * fix(auth): keep the dialog controller's auth-state lambda live across recompositions
…2509) * fix(auth): localize user-facing auth errors by Firebase error code * fix(auth): translate the strings left as English across 84 locales * fix(auth): stop auth errors leaking the Firebase SDK's English diagnostic * fix(auth): translate the password policy and passkey strings across 84 locales * test(auth): drop the bytecode sweep and tests that assert unreachable inputs * refactor(auth): derive the dismiss action from isRecoverable instead of duplicating it * fix(auth): use the credentials hook for expired user tokens, not the account-generic one * docs(auth): document how auth error messages resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.