Skip to content

fix(e2e): fix flaky Google credential-linking test #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
demolaf wants to merge 1 commit into
base: version-10.0.0-beta05
Choose a base branch
from
+12 −2
Open

fix(e2e): fix flaky Google credential-linking test #2455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions e2eTest/src/test/java/com/firebase/ui/auth/ui/screens/CredentialLinkingScreenTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,16 @@ class CredentialLinkingScreenTest {
shadowOf(Looper.getMainLooper()).idle()

// Step 7: Wait for success
// Note: `currentAuthState` may already be `AuthState.Success` from the initial
// email/password sign-in, so checking `is AuthState.Success` alone can pass
// immediately before the phone link has actually completed. Wait for the
// linked provider to actually show up on the (mutated-in-place) user instead.
println("TEST: Waiting for auth state change after phone verification...")
composeTestRule.waitUntil(timeoutMillis = AUTH_STATE_WAIT_TIMEOUT_MS) {
shadowOf(Looper.getMainLooper()).idle()
println("TEST: Auth state: $currentAuthState")
currentAuthState is AuthState.Success
val state = currentAuthState
state is AuthState.Success && state.user.providerData.any { it.providerId == "phone" }
}

// Step 8: Verify the UID is preserved (linking happened, not a new account)
Expand Down Expand Up @@ -369,11 +374,16 @@ class CredentialLinkingScreenTest {
shadowOf(Looper.getMainLooper()).idle()

// Step 6: Wait for linking to complete
// Note: `currentAuthState` may already be `AuthState.Success` from the initial
// email/password sign-in, so checking `is AuthState.Success` alone can pass
// immediately before the Google link has actually completed. Wait for the
// linked provider to actually show up on the (mutated-in-place) user instead.
println("TEST: Waiting for Google linking to complete...")
composeTestRule.waitUntil(timeoutMillis = AUTH_STATE_WAIT_TIMEOUT_MS) {
shadowOf(Looper.getMainLooper()).idle()
println("TEST: Auth state: $currentAuthState")
currentAuthState is AuthState.Success
val state = currentAuthState
state is AuthState.Success && state.user.providerData.any { it.providerId == "google.com" }
}

// Step 7: Verify the UID is preserved and Google provider is added
Expand Down