Repository navigation
Measure test coverage of Numba jit-compiled code - #724
Draft
santisoler wants to merge 9 commits into
Draft
santisoler wants to merge 9 commits into
santisoler wants to merge 9 commits into
Conversation
Configure pytest in the `Makefile` and `pyproject.toml` to track down test coverage within Numba functions.
Remove the now obsolete `run_only_with_numba` decorator. Get rid of the `pytest.mark.use_numba` mark since we don't need it anymore. Remove the `pragma` comments that were intended to ignore coverage within test functions that were only run with Numba enabled.
Member
Author
|
TODO:
|
We perform a similar test on a larger problem. This test was intended to cover Numba functions without taking too much time.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce tests to a single run of
pytestwithNUMBA_JIT_COVERAGEenabled, so Numba can track coverage through JIT compiled functions. However, branch analysis doesn't work properly and has to be disable by a comment# pragma: no branchon everyfor,if, etc. Still this is better than running the tests twice every time. Replace the rules in the Makefile. Add a section to the Contributing Guide explaining why we have all thepragmacomments.Relevant issues/PRs: Inspired by fatiando/choclo#211
Have you used generative AI tools to develop this PR?