Skip to content

fix(tests): fix variable name during test failues, and deal with python upgrade - #1612

Merged
zkat merged 1 commit into
mainfrom
zkat/badstatus
Nov 3, 2026
Merged

zkat merged 1 commit into
mainfrom
zkat/badstatus

Conversation

@zkat

@zkat zkat commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

This fixes two issues that were affecting us and preventing main from passing:

  1. The github test runner upgraded Python to 3.13, which deprecated its cgi built-in module. This module is used by WPT tests, so those started breaking. Now, we install the legacy-cgi module from pip, which backfills it.
  2. There was a bug when checking statuses that for some reason wasn't cropping up before? I tossed this fix in there because it started biting us after we ran out of config-stores recently.

@zkat
zkat enabled auto-merge (squash) November 2, 2026 19:51
@zkat
zkat force-pushed the zkat/badstatus branch 3 times, most recently from e81916f to c024383 Compare November 2, 2026 22:43
@zkat
zkat requested a review from TartanLlama November 2, 2026 23:21
@zkat zkat changed the title fix(tests): fix tests using wrong variable name fix(tests): fix variable name during test failues, and deal with python upgrade Nov 3, 2026
@zkat
zkat merged commit 0e4c267 into main Nov 3, 2026
29 checks passed
@zkat
zkat deleted the zkat/badstatus branch November 3, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants