Skip to content

ci(release): sign the release commit - #242

Merged
Eomm merged 1 commit into
mainfrom
ci/signed-release-commit
Oct 17, 2026
Merged

Eomm merged 1 commit into
mainfrom
ci/signed-release-commit

Conversation

@Eomm

@Eomm Eomm commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

The release commit (Bumped vX.Y.Z) is unsigned, so GitHub does not show it as Verified.

Changes to reusable-release.yml:

  • create the release commit with the GraphQL createCommitOnBranch mutation instead of git commit + git push. GitHub signs commits created through the API with GITHUB_TOKEN, so the commit is Verified and still authored by github-actions[bot]
  • commit the files from the git index (git add -u after npm version), so later npm install changes are not committed
  • expectedHeadOid makes the call fail if the branch moved, same as a non-fast-forward push
  • persist-credentials: false, because nothing is pushed over git any more
  • README: update the note on required permissions

No changes needed in caller workflows.

Tested in Eomm/fastify-raw-body#98, release run: https://github.com/Eomm/fastify-raw-body/actions/runs/38044097927

Result:

image

Comment thread .github/workflows/reusable-release.yml Outdated
Tony133
Tony133 previously approved these changes Oct 17, 2026

@Tony133 Tony133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Tony133 Tony133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Eomm
Eomm merged commit 9001779 into main Oct 17, 2026
3 checks passed
@Eomm
Eomm deleted the ci/signed-release-commit branch October 17, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants