feat: support render function for json directory listings - #608
Open
lx3133584 wants to merge 1 commit into
Open
Conversation
Fixes fastify#221 Signed-off-by: Liang Xu <lx3133584@users.noreply.github.com>
lx3133584
force-pushed
the
feat/dir-list-json-render
branch
from
August 27, 2026 10:11
e8f6a7a to
7fe432b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
list.formatis set tojson(or default JSON mode), configuring a customlist.renderfunction was ignored for JSON responses and only invoked when querying with?format=html.Root Cause
dirList.sendhandledlist.renderexclusively inside theformat === 'html'branch, skipping user-defined custom directory rendering for JSON output.Fix
dirList.sendto invokeoptions.render(dirs, files, format)for JSON listings whenlist.renderis provided.ListJsonRenderandListFormatto TypeScript declarations and extended test definitions intypes/index.tst.ts.README.md.Testing
test/dir-list.test.jsverifying custom JSON rendering and format argument propagation.