Skip to content

refactor(types): move index.d.ts and rename test-types - #233

Open
Tony133 wants to merge 2 commits into
mainfrom
refactor/reorganize-types
Open

refactor(types): move index.d.ts and rename test-types#233
Tony133 wants to merge 2 commits into
mainfrom
refactor/reorganize-types

Conversation

@Tony133

@Tony133 Tony133 commented Aug 18, 2026

Copy link
Copy Markdown
Member

Proposal:

  • Moved index.d.ts into types/
  • Renamed test-types/ to types/
  • Updated package.json accordingly
  • Kept the existing type tests under the new structure

Note:

  • This reorganizes the type definitions and type tests into a single types/ directory, keeping the project structure consistent with the other repositories.

@Tony133
Tony133 force-pushed the refactor/reorganize-types branch from 8884c66 to dd08fea Compare August 18, 2026 20:41
@Tony133
Tony133 marked this pull request as ready for review August 18, 2026 20:45
@Tony133

Tony133 commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

cc @fastify/typescript

@Tony133
Tony133 requested a review from a team August 28, 2026 08:28
@Fdawgs
Fdawgs requested a lite review from Copilot August 28, 2026 10:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes the TypeScript surface area by moving the package declaration file into types/ and colocating type tests alongside it, updating the package entrypoint for typings accordingly.

Changes:

  • Point package.json#types to types/index.d.ts.
  • Add/relocate type tests under types/ (query/transaction/initialization/imports).
  • Introduce the moved declaration file at types/index.d.ts.

Reviewed changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
types/transaction.tst.ts Adds transaction-related type tests, including route-level pg.transact usage.
types/query.tst.ts Adds query-related type tests for app.pg and pg client/query typing.
types/initialization.tst.ts Adds type tests for registration variants (native, custom pg, multiple db names, pool options).
types/index.d.ts Declares Fastify module augmentation and plugin/public API types under the new types/ location.
types/imports.tst.ts Updates import paths for the new layout and validates import forms.
package.json Updates the types entry to the new declaration file location.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants