refactor(types): move index.d.ts and rename test-types - #233
Open
Tony133 wants to merge 2 commits into
Open
Conversation
Tony133
force-pushed
the
refactor/reorganize-types
branch
from
August 18, 2026 20:41
8884c66 to
dd08fea
Compare
Tony133
marked this pull request as ready for review
August 18, 2026 20:45
Member
Author
|
cc @fastify/typescript |
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the TypeScript surface area by moving the package declaration file into types/ and colocating type tests alongside it, updating the package entrypoint for typings accordingly.
Changes:
- Point
package.json#typestotypes/index.d.ts. - Add/relocate type tests under
types/(query/transaction/initialization/imports). - Introduce the moved declaration file at
types/index.d.ts.
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| types/transaction.tst.ts | Adds transaction-related type tests, including route-level pg.transact usage. |
| types/query.tst.ts | Adds query-related type tests for app.pg and pg client/query typing. |
| types/initialization.tst.ts | Adds type tests for registration variants (native, custom pg, multiple db names, pool options). |
| types/index.d.ts | Declares Fastify module augmentation and plugin/public API types under the new types/ location. |
| types/imports.tst.ts | Updates import paths for the new layout and validates import forms. |
| package.json | Updates the types entry to the new declaration file location. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
index.d.tsintotypes/test-types/totypes/package.jsonaccordinglyNote:
types/directory, keeping the project structure consistent with the other repositories.