fix(typing): widen Container.bind name param to str | type - #198
Merged
Conversation
simple() binds a class object as the container key (mirroring make()'s class-key support at 'elif inspect.isclass(name)'). The str-only signature from #197 was too narrow, producing a pyright error at container.py:92: 'Argument of type type[object] | Unknown cannot be assigned to parameter name of type str'. Widen name to str | type to match the keys make() accepts. Typing-only change; bind still returns None.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #197 (merged as
7767a5cb). Post-merge review found one genuine new pyright error thebind()narrowing introduced.Root cause
Container.simple()binds a class object as the container key:This mirrors
make()'s class-key support (elif inspect.isclass(name):). Thestr-onlybind(name: str, ...)signature from #197 was too narrow, so pyright errored atcontainer/container.py:92:Change
One-line signature widening —
name: str→name: str | type, matching the key typesmake()accepts. No runtime change;bindstill returnsNone.Verification
uv run pyright src/.../container.py: 0 errors (was 1 at:92). Before/after confirmed by temporarily reverting.uv run pyright(full project): 0 container.py diagnostics; total 656 errors — no new errors introduced.uv run pytest --ignore=tests/masoniteorm/postgres: 1981 passed, 7 skipped (incl.tests/core/test_container.py: 52 passed).ruff check+ruff format --check: clean.