cmake: fix CXX flag dependency in AddZstdCompilationFlags when C++ is not enabled - #4810
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
… not enabled Signed-off-by: Tyagiquamar <mohdquamartyagi@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #4800.
Since #4357, the CMake build enables C++ only when tests are enabled (
ZSTD_BUILD_TESTS=ON), butAddZstdCompilationFlags.cmakestill invokedCHECK_CXX_COMPILER_FLAGwheneverCMAKE_CXX_COMPILERwas defined in the environment or toolchain (such as standard MinGW/cross-compilation toolchains).When C++ is not enabled as a CMake project language:
CHECK_CXX_COMPILER_FLAGfails withcheck_compiler_flag: CXX: needs to be enabled before use.CMAKE_CXX_COMPILER_ID(which is empty when C++ is not loaded), causing default C-only builds to lose standard warnings (-Wall,-Wextra, etc.) and assembly support.ZSTD_HAS_NOEXECSTACKunconditionally requiredCXX_FLAG_WA_NOEXECSTACKto be set.This change:
EnableCompilerFlagto check C++ compiler flags only whenCMAKE_CXX_COMPILER_LOADEDis true.ADD_ZSTD_COMPILATION_FLAGSto evaluateCMAKE_C_COMPILER_IDandCMAKE_CXX_COMPILER_ID.${_C},${_CXX},${_LD}toEnableCompilerFlag.ZSTD_HAS_NOEXECSTACKto succeed in C-only mode without requiring C++CXX_FLAG_WA_NOEXECSTACK.Validation
cmake -S build/cmake -B /tmp/zstd-build -G Ninja -DCMAKE_BUILD_TYPE=Release && cmake --build /tmp/zstd-build).-Wall,-Wextra,-Wshadow, etc.),libzstd.a,libzstd.so, and executable binaries build and link with exit code 0.