fix(ci): fix TS6 upgrade + prepare for TS7#12287
Merged
Merged
Conversation
slorber
added
the
pr: maintenance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: -844 B (-0.01%) Total Size: 12 MB 📦 View Changed
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -907 B (-0.01%) Total Size: 12.4 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After upgrading to TS6, I forgot to reactivate deprecation warnings, and remove
baseUrl(deprecated): #11915Now that TS7 is out, we also want to upgrade to it, however it's likely blocked due to TS-ESLint until v7.1 is out: #12264
Even if we keep our monorepo on TS6 for now, our CI still type-checks Docusaurus website against TS7 (without running lints), so this PR also adjust our code so that it can pass typechecks on both TS6 + TS7, reducing the scope of the TS7 upgrade PR
Test Plan
CI