fix(view): treat names ending in '.' as extensionless - #7411
Closed
CSTRSK wants to merge 1 commit into
Closed
Conversation
path.extname('index.') returns '.', which is truthy, so the
'no extension -> use default engine' fallback was skipped and
this.ext.slice(1) became '', causing require('') to throw an
opaque TypeError synchronously.
Normalize ext === '.' to '' so the default engine applies and
lookup fails with the usual 'Failed to lookup view' error.
Contributor
|
Duplicate of #7351 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7350
res.render('index.')/app.render('index.')threw a synchronous, opaqueTypeError [ERR_INVALID_ARG_VALUE]fromrequire(''), instead of the usual helpfulFailed to lookup viewerror.Root cause
path.extname('index.')returns'.', which is truthy — so the "no extension → use default engine" fallback inlib/view.jswas skipped.this.extstayed'.'andthis.ext.slice(1)became'', sorequire('')was called and threw synchronously, bypassing the render callback entirely.Change
Normalize
ext === '.'to''at the top of theViewconstructor. The default-engine fallback then applies, and lookup fails cleanly through the normal callback path:This also covers
app.set('view engine', ...)setups, exactly as reported.Tests
Added a regression test in
test/app.render.js. Full suite passes: 1153 passing (+1 new), eslint clean.