Repository navigation
fix(test): pin supertest to 7.3.0 to avoid 7.3.1 regression - #773
Merged
UlisesGascon merged 1 commit intoOct 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
UlisesGascon
approved these changes
Oct 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supertest@7.3.1contains a regression that breaks this repository's test suite, as reported in #772. The^7.2.2range indevDependenciesnow resolves to 7.3.1, so a fresh install fails even though no library code has changed. No fixed supertest release is available yet (7.3.1 is still the latest release), so this pinssupertestto 7.3.0, the last known working version, as suggested in #772. The pin can be lifted once a fixed supertest release is published.The failing tests are the ones that stream a body with
.write()on the request (for example the charset and chunked-encoding cases): with 7.3.1 they fail withError: ECONNREFUSED: Connection refusedfrom supertest's server handling, while the same tests pass on 7.3.0.Changes
package.json: change thesupertestdevDependency from^7.2.2to the exact version7.3.0, so fresh installs no longer resolve to the regressed 7.3.1 release.Tests
Baseline, with
supertest@7.3.1installed:npx mocha --reporter spec test/json.js- 39 passing, 27 failing (all failures areError: ECONNREFUSED: Connection refusedin tests using.write())With
supertest@7.3.0pinned by this change:npx mocha --reporter dot --check-leaks test/- 273 passing, 4 pending, 0 failingnpm run lint- passedFixes #772