[eas-cli] Accept navigation metric aliases as positional args to observe:metrics#3973
Open
douglowder wants to merge 2 commits into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
douglowder
requested review from
Ubax,
jonsamp and
tsapeta
and removed request for
tsapeta
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3973 +/- ##
==========================================
+ Coverage 59.33% 59.33% +0.01%
==========================================
Files 936 936
Lines 41172 41177 +5
Branches 8671 8675 +4
==========================================
+ Hits 24424 24429 +5
Misses 16654 16654
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…rve:metrics The observe:metrics command listed navigation metrics in the interactive metric picker (via METRIC_SHORT_NAMES) but its positional-arg validator was restricted to Object.keys(METRIC_ALIASES), so `eas observe:metrics nav_tti` and the other nav aliases were rejected by oclif before the resolver ever saw them. Widen the arg's `options` to include NAVIGATION_METRIC_ALIASES, extend resolveMetricName to resolve navigation short aliases (cold_ttr, warm_ttr, nav_tti) to their expo.navigation.* full names, and include both alias sets in the non-interactive-mode "available metrics" error message. resolveNavigationMetricName remains for observe:routes, which should not accept app-startup metric names. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
douglowder
force-pushed
the
doug/eng-23109-eas-cli-include-navigation-metric-names-in-observemetrics
branch
from
6c61818 to
a109535
Compare
|
✅ Thank you for adding the changelog entry! |
Ubax
reviewed
Jul 7, 2026
Comment on lines
3
to
16
| export const METRIC_ALIASES: Record<string, string> = { | ||
| tti: 'expo.app_startup.tti', | ||
| ttr: 'expo.app_startup.ttr', | ||
| cold_launch: 'expo.app_startup.cold_launch_time', | ||
| warm_launch: 'expo.app_startup.warm_launch_time', | ||
| bundle_load: 'expo.app_startup.bundle_load_time', | ||
| update_download: 'expo.updates.download_time', | ||
| }; | ||
|
|
||
| export const NAVIGATION_METRIC_ALIASES: Record<string, string> = { | ||
| cold_ttr: 'expo.navigation.cold_ttr', | ||
| warm_ttr: 'expo.navigation.warm_ttr', | ||
| nav_cold_ttr: 'expo.navigation.cold_ttr', | ||
| nav_warm_ttr: 'expo.navigation.warm_ttr', | ||
| nav_tti: 'expo.navigation.tti', | ||
| }; |
There was a problem hiding this comment.
Can we combine them into single METRIC_ALIASES?
Something like:
export const METRIC_ALIASES: Record<string, string> = {
...NAVIGATION_METRIC_ALIASES,
tti: 'expo.app_startup.tti',
ttr: 'expo.app_startup.ttr',
cold_launch: 'expo.app_startup.cold_launch_time',
warm_launch: 'expo.app_startup.warm_launch_time',
bundle_load: 'expo.app_startup.bundle_load_time',
update_download: 'expo.updates.download_time',
}Then you could remove
if (NAVIGATION_METRIC_ALIASES[input]) {
return NAVIGATION_METRIC_ALIASES[input];
}and
KNOWN_FULL_NAVIGATION_NAMES.has(input) ||
Comment on lines
+60
to
+61
| expect(() => resolveMetricName('bogus')).toThrow(/nav_tti/); | ||
| expect(() => resolveMetricName('bogus')).toThrow(/cold_launch/); |
There was a problem hiding this comment.
Can you modify this tests to be a bit more accurate?
Maybe even something like:
expect(() => resolveMetricName('bogus')).toMatchSnapshot();This would make it easy to update, yet verify that all the metrics are there
| description: 'Metric to query (e.g. tti, cold_launch, nav_tti)', | ||
| required: false, | ||
| options: Object.keys(METRIC_ALIASES), | ||
| options: [...Object.keys(METRIC_ALIASES), ...Object.keys(NAVIGATION_METRIC_ALIASES)], |
There was a problem hiding this comment.
This could be reverted if the metrics are spread in METRIC_ALIASES
Comment on lines
+13
to
+14
| nav_cold_ttr: 'expo.navigation.cold_ttr', | ||
| nav_warm_ttr: 'expo.navigation.warm_ttr', |
There was a problem hiding this comment.
Should we display a warning if someone uses the old aliases? I'm not sure if we advertised this as stable or unstable (we can just remove the alias without a breaking change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When running
observe:metricsin non-interactive mode, navigation metric names could not be passed into the command; only app startup metrics were accepted.How
Test Plan