[build-tools] Add eas/posthog_upload_sourcemaps workflow function#3947
Open
gwdp wants to merge 1 commit into
Open
[build-tools] Add eas/posthog_upload_sourcemaps workflow function#3947gwdp wants to merge 1 commit into
gwdp wants to merge 1 commit into
Conversation
This was referenced Jul 3, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
229312f to
98e807a
Compare
8d13771 to
a8e1b57
Compare
98e807a to
f34df26
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gwdp/eng-21551-posthog-wait-for-metric #3947 +/- ##
==========================================================================
+ Coverage 59.69% 59.71% +0.03%
==========================================================================
Files 942 943 +1
Lines 41555 41579 +24
Branches 8757 8758 +1
==========================================================================
+ Hits 24802 24826 +24
Misses 16659 16659
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b6df873 to
eb91e64
Compare
a8e1b57 to
f630079
Compare
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
sjchmiela
approved these changes
Jul 6, 2026
| logger.info(`Uploading source maps from "${directory}" to PostHog`); | ||
| try { | ||
| await spawn( | ||
| 'npx', |
Contributor
There was a problem hiding this comment.
i think we might need -y?
eb91e64 to
7d0223e
Compare
28718f6 to
6e72fed
Compare
6952ef5 to
fc5c5d9
Compare
6e72fed to
2755d8a
Compare
fc5c5d9 to
abdc0c9
Compare
58cfdcf to
9d6b3f4
Compare
fc81011 to
cdfc8f9
Compare
9d6b3f4 to
01a7642
Compare
01a7642 to
9a9a276
Compare
cdfc8f9 to
82b0571
Compare
82b0571 to
d089cc8
Compare
9a9a276 to
bc4056b
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Upload your app's source maps to PostHog from a workflow, so error-tracking stack traces are readable instead of minified. For EAS Update and custom builds, where the automatic build-time upload doesn't run.
How
Adds
eas/posthog_upload_sourcemaps. Runs@posthog/cli hermes uploadagainst adirectory(defaultdist) with the connect step'sPOSTHOG_CLI_*creds. Chunk IDs are injected at bundle time by PostHog's Expo metro config (getPostHogExpoConfig), so this step just ships what's already in the export.ignore_error(default false) fails the step on an upload error; set it true to warn and continue.(This is the outlier of the posthog functions, but felt the right call, defaults to fail; Lmk if different thoughts)
Test Plan
CI passes. Ran it live against coin-flip with the metro config in place:
expo export --source-mapsthen this step uploaded the Hermes map to PostHog (Found 1 maps to upload,1 upload keys). Test workflow below covers the happy path plus a forced failure and an ignored one.Test workflow