Skip to content

[steps] Expand local actions at parse time#3929

Draft
sswrk wants to merge 1 commit into
szymonswierk/eng-22387-steps-local-action-discoveryfrom
szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time
Draft

[steps] Expand local actions at parse time#3929
sswrk wants to merge 1 commit into
szymonswierk/eng-22387-steps-local-action-discoveryfrom
szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time

Conversation

@sswrk

@sswrk sswrk commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Why

Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.

How

How did you build this feature or fix this bug and why?

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

@linear-code

linear-code Bot commented Jul 1, 2026

Copy link
Copy Markdown

ENG-22387

sswrk commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sswrk sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from 95118f3 to 622179a Compare July 1, 2026 16:50
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from 72189ae to 4764420 Compare July 1, 2026 16:50
@sswrk sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from 622179a to ff953ae Compare July 2, 2026 16:56
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from 4764420 to 56ee52f Compare July 2, 2026 16:56
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.01916% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.54%. Comparing base (c230ee8) to head (4de54ff).

Files with missing lines Patch % Lines
packages/steps/src/utils/actionInterpolation.ts 91.47% 7 Missing ⚠️
packages/steps/src/ActionExpander.ts 97.23% 3 Missing and 1 partial ⚠️
packages/steps/src/StepsConfigParser.ts 94.45% 1 Missing ⚠️
packages/steps/src/utils/step.ts 92.31% 1 Missing ⚠️
Additional details and impacted files
@@                                   Coverage Diff                                   @@
##           szymonswierk/eng-22387-steps-local-action-discovery    #3929      +/-   ##
=======================================================================================
+ Coverage                                                59.33%   59.54%   +0.22%     
=======================================================================================
  Files                                                      937      940       +3     
  Lines                                                    41154    41397     +243     
  Branches                                                  8671     8746      +75     
=======================================================================================
+ Hits                                                     24414    24646     +232     
- Misses                                                   16646    16656      +10     
- Partials                                                    94       95       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from 56ee52f to e436769 Compare July 3, 2026 13:43
@sswrk sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from ff953ae to 77773ec Compare July 3, 2026 13:43
@sswrk sswrk changed the title [steps] Expand custom actions at parse time [steps] Expand local actions at parse time Jul 3, 2026
@sswrk sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from 77773ec to d1bbabd Compare July 3, 2026 14:08
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch 2 times, most recently from 92fe812 to 3e774f9 Compare July 3, 2026 14:46
@sswrk sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from d1bbabd to 6cd3f30 Compare July 3, 2026 14:46
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from 3e774f9 to f74b6da Compare July 3, 2026 14:58
@sswrk sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from 6cd3f30 to 85cc322 Compare July 3, 2026 14:58
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from f74b6da to b5be21a Compare July 3, 2026 15:40
@sswrk sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch 2 times, most recently from 244427d to e64f37d Compare July 3, 2026 15:48
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from b5be21a to 1e89296 Compare July 3, 2026 15:48
@sswrk sswrk changed the base branch from szymonswierk/eng-22387-eas-build-job-local-action-schema to graphite-base/3929 July 6, 2026 12:11
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from 1e89296 to 4f79fdc Compare July 6, 2026 12:11
@sswrk sswrk changed the base branch from graphite-base/3929 to szymonswierk/eng-22387-steps-local-action-discovery July 6, 2026 12:11
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from 2046da9 to bf2e850 Compare July 6, 2026 13:23
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch 2 times, most recently from 2190527 to 8d70398 Compare July 6, 2026 13:51
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from bf2e850 to ea3cab3 Compare July 6, 2026 14:49
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch 2 times, most recently from 24e94a3 to 8e65aa9 Compare July 6, 2026 15:20
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from ea3cab3 to c230ee8 Compare July 6, 2026 15:20
@sswrk sswrk force-pushed the szymonswierk/eng-22387-steps-expand-custom-actions-at-parse-time branch from 8e65aa9 to 4de54ff Compare July 6, 2026 15:34
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant