Skip to content

chore(kms): add delete-at field#869

Open
luxium30 wants to merge 2 commits into
masterfrom
leoloch/sc-187005/exo-cli-add-delete-at-field
Open

chore(kms): add delete-at field#869
luxium30 wants to merge 2 commits into
masterfrom
leoloch/sc-187005/exo-cli-add-delete-at-field

Conversation

@luxium30

@luxium30 luxium30 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds the delete-at field for KMS keys. The convention is printing out every field, even when unset.

go run main.go kms key show 019e9327-0059-702f-b211-e2e0217f982c --zone de-fra-1

┼─────────────────┼────────────────────────────────────────────────────┼
│     KMS KEY     │                                                    │
┼─────────────────┼────────────────────────────────────────────────────┼
│ ID              │ 019e9327-0059-702f-b211-e2e0217f982c               │
│ Name            │ serf                                               │
│ Created At      │ 2026-06-04 15:01:07.289146061 +0000 UTC            │
│ Multizone       │ false                                              │
│ Origin Zone     │ de-fra-1                                           │
│ Status          │ enabled                                            │
│ Replicas Status │ -                                                  │
│ Material        │ auto: false                                        │
│                 │ createdAt: 2026-06-04 15:01:07.289146061 +0000 UTC │
│                 │ version: 1                                         │
│ Rotation        │ auto: true                                         │
│                 │ count: 0                                           │
│                 │ nextAt: 2027-06-04 15:01:07.292841723 +0000 UTC    │
│                 │ rotationPeriod: 365                                │
│ Usage           │ encrypt-decrypt                                    │
│ Source          │ exoscale-kms                                       │
│ Description     │ sdfsef                                             │
│ Delete At       │ n/a                                                │
┼─────────────────┼────────────────────────────────────────────────────┼

go run main.go kms key show 019ef4a7-c5d9-7880-8a78-4ebfaacb4423

┼─────────────────┼────────────────────────────────────────────────────┼
│     KMS KEY     │                                                    │
┼─────────────────┼────────────────────────────────────────────────────┼
│ ID              │ 019ef4a7-c5d9-7880-8a78-4ebfaacb4423               │
│ Name            │ aab                                                │
│ Created At      │ 2026-06-23 13:26:15.647876511 +0000 UTC            │
│ Multizone       │ false                                              │
│ Origin Zone     │ ch-gva-2                                           │
│ Status          │ pending-deletion                                   │
│ Replicas Status │ -                                                  │
│ Material        │ auto: false                                        │
│                 │ createdAt: 2026-06-23 13:26:15.647876511 +0000 UTC │
│                 │ version: 2                                         │
│ Rotation        │ auto: true                                         │
│                 │ count: 1                                           │
│                 │ nextAt: 2027-06-23 13:24:56.41204593 +0000 UTC     │
│                 │ rotationPeriod: 365                                │
│ Usage           │ encrypt-decrypt                                    │
│ Source          │ exoscale-kms                                       │
│ Description     │                                                    │
│ Delete At       │ 2026-07-22 09:51:26.813122066 +0000 UTC            │
┼─────────────────┼────────────────────────────────────────────────────┼

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block, and add the Pull Request #number for each bit you add to the CHANGELOG.md)
  • Testing

Testing

@luxium30 luxium30 changed the title fix(kms): add delete-at field chore(kms): add delete-at field Jul 8, 2026
@luxium30 luxium30 requested a review from a team July 9, 2026 07:25
@luxium30 luxium30 force-pushed the leoloch/sc-187005/exo-cli-add-delete-at-field branch 2 times, most recently from 135a3f1 to f134410 Compare July 10, 2026 16:21
@quentinalbertone quentinalbertone force-pushed the leoloch/sc-187005/exo-cli-add-delete-at-field branch from f134410 to dadba3d Compare July 13, 2026 13:56
Comment thread pkg/output/outputter.go Outdated

@jbelo jbelo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should understand the effect of removing a time.Time field, when it is zero, from all output.

@luxium30 luxium30 requested review from emilehreich and jbelo July 15, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants