Skip to content

Clean-up unneeded code following upstream sidebar fixes - #1026

Open
Yann-P wants to merge 2 commits into
executablebooks:mainfrom
Yann-P:claude/beautiful-mayer-0jso81
Open

Yann-P wants to merge 2 commits into
executablebooks:mainfrom
Yann-P:claude/beautiful-mayer-0jso81

Conversation

@Yann-P

@Yann-P Yann-P commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Fixes #1006

Removes useless code that was coping with the fact that PST < 0.23.0 ignored the one-sidebar configuration overrides SBT relies on.

pydata-sphinx-theme 0.23.0 respects theme.conf overrides, so the empty
navbar_persistent from theme.conf is honoured without forcing it at
builder-inited. Follow-up to executablebooks#987, closes executablebooks#1006.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LQGTZApsK5oZks3B8fdbEy
pydata-sphinx-theme 0.23.0 no longer renders #pst-primary-sidebar-checkbox;
wide-screen collapse is handled by the .pst-sidebar-hidden class instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LQGTZApsK5oZks3B8fdbEy
@choldgraf

Copy link
Copy Markdown
Member

Yann what do you think about me adding you as a maintainer on this repo? I'd trust you to merge PRs like this, and you have familiarity with jupyter and the pydata theme in general.

@Yann-P

Yann-P commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

Hi Chris, thanks!

I still don't know much about Sphinx Book Theme, but if I can help reducing maintainers load by handling upstream matters more autonomously, I'd be happy to.

@Yann-P

Yann-P commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator Author

SBT CI runs into the same issue as PST a few hours ago due to a sphinx-design change, this kind of PR will fix it. Yann-P/pydata-sphinx-theme#12

@choldgraf

Copy link
Copy Markdown
Member

Essentially the book theme was designed intentionally to inherit as much as possible from the pydata sphinx theme, and to then apply its own layer of design/config to streamline it for jupyter book v1 (used to be built on Sphinx). Nowadays, it doesn't get as much attention because Jupyter Book is now built on the MyST engine (mystmd.org), but I'd love to see sphinx book theme continue to live as an independent theme for folks that get value out of it.

@Yann-P I've invited you as a maintainer!

@bsipocz

bsipocz commented Nov 13, 2026

Copy link
Copy Markdown
Member

I still don't know much about Sphinx Book Theme, but if I can help reducing maintainers load by handling upstream matters more autonomously, I'd be happy to.

That is actually super great. I keep "maintaining" sphinx-book-theme, but as I don't use it any more anywhere it really is just keep sinking to the bottom of a pile, so handling upstream is actually very helpful. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow up on pull/987 when pydata-sphinx-theme 0.23.0 is out

4 participants