Repository navigation
👌 Fix quadratic-time smartquotes on blocks with many quotes - #481
Open
affan-arch wants to merge 1 commit into
Open
affan-arch wants to merge 1 commit into
affan-arch wants to merge 1 commit into
Conversation
Port markdown-it's deferred replacements (9ce2087) and remove the other O(n) work done per quote or per token in process_inlines: the text[pos:] search, the stack copy per token, and the full-stack rescan for a closer with no opener of its kind.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make smartquotes linear in the number of quotes by porting markdown-it's deferred replacements (9ce2087, which upstream lists under Security) and dropping the per-quote
text[pos:]copy, the per-token stack copy and the full-stack rescan for a closer with no opener of its kind; withtypographeron, a 117 KiB block (' "a' * 20_000 + " b'" * 20_000) used to stall a render for ~10 s and now takes 0.03 s, upstream's'"' * 160_000case goes from ~4 s to 0.11 s, and the output matches the old rule on 390k fuzzed inputs.