Skip to content

chore: bump reth 2.2#236

Open
tac0turtle wants to merge 1 commit intomainfrom
marko/reth2.2
Open

chore: bump reth 2.2#236
tac0turtle wants to merge 1 commit intomainfrom
marko/reth2.2

Conversation

@tac0turtle
Copy link
Copy Markdown
Contributor

@tac0turtle tac0turtle commented May 4, 2026

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Refactoring

Related Issues

Fixes #(issue)

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Testing

Additional Notes

Summary by CodeRabbit

  • Chores

    • Upgraded all reth dependencies from v2.1.0 to v2.2.0 and synchronized alloy crates to compatible versions for enhanced stability and performance.
  • Tests

    • Added comprehensive end-to-end test coverage for Viem-based ETH transfer operations, validating gas estimation accuracy and successful transaction processing.

@tac0turtle tac0turtle marked this pull request as ready for review May 4, 2026 08:27
@tac0turtle tac0turtle requested a review from a team as a code owner May 4, 2026 08:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5c8d422b-b1e2-4272-b9b6-5d78ca415c63

📥 Commits

Reviewing files that changed from the base of the PR and between 32f79a0 and 10ae4cd.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml
  • clients/tests/e2e/flows.e2e.test.ts
  • crates/node/src/builder.rs
  • crates/node/src/evm_executor.rs

📝 Walkthrough

Walkthrough

This PR bumps workspace dependencies (reth v2.1.0 to v2.2.0, alloy versions to 2.0.4+), refactors executor implementations to use references instead of cloning and simplifies commit_transaction return types, adds an e2e test for standard Viem transfer flows, and updates logging formatting in the builder.

Changes

Dependency Upgrade & Executor Refactoring

Layer / File(s) Summary
Workspace Dependencies
Cargo.toml
All reth-* git dependencies updated from tag = "v2.1.0" to tag = "v2.2.0". alloy versions bumped to 2.0.4, alloy-evm to 0.34.0, aligned to reth v2.2.0.
Executor API & Trait Bounds
crates/node/src/evm_executor.rs
EvTxResult::TxResult adds H: Send + 'static, T: Send + 'static bounds. EvBlockExecutor::BlockExecutor adds TxType: Send + 'static and changes commit_transaction to return GasOutput directly (removes Result wrapper). EvBlockExecutorFactory::BlockExecutorFactory removes Clone bounds on R and Spec, stores references, and returns Self::Executor<'a, DB, I> with stored field references instead of clones.
Logging Formatting
crates/node/src/builder.rs
debug! log statement updated to use debug formatting (?) for gas_used output.

E2E Test Addition

Layer / File(s) Summary
Test Chain & Imports
clients/tests/e2e/flows.e2e.test.ts
Added Viem imports (createPublicClient, createWalletClient, defineChain) and defined EV_RETH_TEST_CHAIN targeting local Hardhat RPC at 127.0.0.1:8545 (chain id 1234).
Transfer Test Case
clients/tests/e2e/flows.e2e.test.ts
New e2e test "standard viem transfer estimates 21000 gas and sends without gas override" creates clients, generates recipient, estimates gas (asserts 21_000n), sends transfer, verifies receipt status and gasUsed, confirms recipient balance increase.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • randygrok
  • damiannolan

Poem

🐰 Hops of joy for references bright,
No more clones to weigh us down—
Gas flows straight without the Result height,
And tests now bloom across the town!
v2.2.0 brings us newfound light!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description consists entirely of an unfilled template with no substantive content. No description of changes, type of change selection, related issues, testing details, or additional context is provided. Fill in the description section with a summary of the reth 2.2 upgrade, select the appropriate type of change, describe tests performed, and explain any breaking changes or migration steps required.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: bump reth 2.2' accurately summarizes the main change: upgrading the reth dependency to version 2.2, which is the primary focus of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch marko/reth2.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant