Fix typo "mdoel" -> "model" in dump_mdoel_for_chat_completion_request#456
Open
rosaboyle wants to merge 1 commit into
Open
Fix typo "mdoel" -> "model" in dump_mdoel_for_chat_completion_request#456rosaboyle wants to merge 1 commit into
rosaboyle wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.
Pretty sure this should have been model and not mdoel. Please enlighten me otherwise ;)
Note
Low Risk
Pure identifier rename with no logic changes; low risk unless external code still calls the old misspelled method name.
Overview
Renames
Message.dump_mdoel_for_chat_completion_requesttodump_model_for_chat_completion_request(typo fix: mdoel → model).All call sites are updated in rollout processors (
default_agent_rollout_processor,default_single_turn_rollout_process,tracing_utils), remote test server and e2e script, and related tests/comments. Behavior is unchanged—still strips non–chat-completion fields before API requests.Reviewed by Cursor Bugbot for commit fd9b22f. Bugbot is set up for automated code reviews on this repo. Configure here.