Skip to content

Allow runs to localhost #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xzrderek merged 1 commit into from
Nov 28, 2025
Merged

Allow runs to localhost #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eval_protocol/pytest/default_single_turn_rollout_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ async def process_row(row: EvaluationRow) -> EvaluationRow:
request_params = {"messages": messages_payload, **config.completion_params}
# Ensure caching is disabled only for this request (review feedback)
request_params["cache"] = {"no-cache": True}

api_base = os.getenv("EP_LLM_API_BASE") or os.getenv("EP_LLM_BASE_URL")
if api_base and "api_base" not in request_params:
request_params["api_base"] = api_base

@cursor cursor Bot Nov 22, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Environment variable ignored when config has falsy api_base

The check "api_base" not in request_params prevents environment variables from being used when config.completion_params contains api_base with a falsy value like "" or None. This means if someone has an empty or null api_base in their config, the environment variables EP_LLM_API_BASE or EP_LLM_BASE_URL won't override it. The condition should check not request_params.get("api_base") to allow environment variables to override falsy config values.

Fix in Cursor Fix in Web

# Single-level reasoning effort: expect `reasoning_effort` only
effort_val = None

Expand Down
Loading