Repository navigation
feat(tests): extend EIP-2537 MAP_FP_TO_G1 and MAP_FP2_TO_G2 edge-case coverage - #3945
Open
rorupuntou wants to merge 1 commit into
Open
rorupuntou wants to merge 1 commit into
rorupuntou wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @spencer-tb @marioevz! Whenever you have a moment, could you approve the pending CI workflow run and take a quick look at these negative boundary test cases for |
rorupuntou
force-pushed
the
feat/eip2537-map-fp-to-curve-hardening
branch
from
November 3, 2026 21:43
a02a19f to
c9eb5e0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends test coverage for EIP-2537
MAP_FP_TO_G1(precompile0x10) andMAP_FP2_TO_G2(precompile0x11), focusing on input padding, boundary validation, and coordinate modulus checks:0..15of the 64-byte field representations (e.g. byte 150x01, high bit0x80, mid-padding byte 8, and dirty padding paired with a validSpec.P - 1coordinate), verifying that implementations do not ignore dirty upper padding before coordinate validation.MAP_FP2_TO_G2, covers dirty padding individually on0..15), individually on64..79), and simultaneously on bothFpforFp2).All 66 test fixtures generate cleanly against the Prague fork (
uv run fill).Related Issues or PRs
Follow-up to #3641 (rebased onto
forks/bogotafrom #3821).Checklist
just static<type>(<area>): <description>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture