ci: actually run flutter test - #11
Merged
Merged
Conversation
The job is named "Tests & Analyze" but only ever analyzed. Analysis catches API breakage -- it is what surfaced file_picker removing FilePicker.platform -- but it cannot catch a behaviour regression. The suite is only 2 tests, so this is a small gate today. It is the gate that has to exist before it is worth widening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job is named "Tests & Analyze" but only ever analyzed — there was no
flutter teststep.Analysis is not worthless here: it is exactly what surfaced
file_pickerremovingFilePicker.platform, thenFilePickerResult, thenPlatformFile.sizeacross #8 and #10. But it can only catch API breakage. It cannot catch a behaviour regression, and it never will.Honest caveat: the suite is 2 tests, so this is a small gate today. It is the gate that has to exist before widening it is worth anything — right now adding a test buys you nothing in CI, which is a bad incentive.
The natural next step is widget coverage for
FileDropzone, which is both the most logic-heavy widget and the one that just absorbed three breaking API changes. That needs the platform channel mocked, so it is its own piece of work rather than something to bolt onto a CI change.