Updates_20261001 release prep: version bumps - #898
Merged
Merged
Conversation
The ten combined-install procs move to .10, and sp_QueryStoreCleanup moves from 1.6 to 1.10 because it changed this cycle. Version date 20261001 for all eleven. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dr8NyHme4WMWdwyz99UxWq
|
Claude finished @erikdarlingdata's task in 8s —— View job Review: Updates_20261001 version bumpsThe changes look good. I found nothing to flag.
I only read the diff. I didn't run any SQL. |
Release style audit: the comment on @find_duplicate_plans' date filter in sp_QuickieCache, and the APPLY comment at both sp_HumanEventsBlockViewer sites, started their text on the /* line. The text is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dr8NyHme4WMWdwyz99UxWq
|
Claude finished @erikdarlingdata's task in 14s —— View job Review: Updates_20261001 version bumps (updated for the new commit)The changes look good. I found nothing to flag.
I only read the diff. I didn't run any SQL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bumps for
Updates_20261001. The ten procs in the combined installer move to.10, with version date20261001.sp_QueryStoreCleanupis not in the combined installer. It moved with the other procs until the May release. After that it stayed at 1.6, because its code did not change. In this cycle, 15 commits changed it. They added@sort_direction,@compact_tables, the summary report, and the binary-collation text search, and they changed how PSP parent queries are removed. So it moves to 1.10 with the other procs.ProtectSession and TestBackupPerformance did not change, so they keep their versions.
Two version lines change in each file, 22 lines in total.
Style audit
Three read-only reviewers checked every line that this cycle added to the ten changed procs against the style guide. A scan of the same lines found no tabs,
EXEC,int,CAST,COUNT(,@@ROWCOUNT,(MAX), bareTOP, or--comments.The second commit fixes the one finding that needed a change. Three new multi-line comments started their text on the
/*line: one insp_QuickieCacheand two insp_HumanEventsBlockViewer. Their delimiters are now on their own lines, and the text is unchanged.These findings stay as they are, because they match conventions that the files already use:
IF @debug = 1 BEGIN RAISERROR ... END;inside dynamic SQL. The same form was already in the code 90 times, for example 64 times insp_HumanEvents.REPLACEcalls insp_HealthParser. The other tenREPLACEcalls in that file use the same indent.🤖 Generated with Claude Code
https://claude.ai/code/session_01Dr8NyHme4WMWdwyz99UxWq