Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
See all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
ericmann
two-factor
Repository navigation
Code
Pull requests
1
(1)
Actions
Projects
Wiki
Security and quality
Insights
More
items
Build: build/2026-09-28
- #1
#1
Closed
ericmann
wants to merge 59 commits into
master
ericmann/two-factor:master
from
build/2026-09-28
ericmann/two-factor:build/2026-09-28
Copy head branch name to clipboard
Conversation
Commits
59
(59)
Checks
Files changed
Closed
Build: build/2026-09-28
#1
ericmann
wants to merge 59 commits into
master
ericmann/two-factor:master
from
build/2026-09-28
ericmann/two-factor:build/2026-09-28
Copy head branch name to clipboard
Commits
Commits on Sep 28, 2026
plan: derive build plan from SPEC
ericmann
committed
8799d03
View commit details
Copy full SHA for 8799d03
Browse repository at this point
chore: start implementation run
ericmann
committed
9a4a1c3
View commit details
Copy full SHA for 9a4a1c3
Browse repository at this point
chore: run halted
ericmann
committed
adb3bdf
View commit details
Copy full SHA for adb3bdf
Browse repository at this point
P0-01 (partial): load Secrets API feature plugin in tests env
Show description for e9e18d7
ericmann
committed
e9e18d7
View commit details
Copy full SHA for e9e18d7
Browse repository at this point
foundry: clear operator halt
ericmann
committed
ba6e745
View commit details
Copy full SHA for ba6e745
Browse repository at this point
P0-01: load Secrets API feature plugin in tests env
Show description for f54ffa6
ericmann
committed
f54ffa6
View commit details
Copy full SHA for f54ffa6
Browse repository at this point
progress: P0-01 done
ericmann
committed
8a204c8
View commit details
Copy full SHA for 8a204c8
Browse repository at this point
P0-02: PHPStan stubs for the Secrets API
Show description for 51fff02
ericmann
committed
51fff02
View commit details
Copy full SHA for 51fff02
Browse repository at this point
progress: P0-02 done
ericmann
committed
158fc6a
View commit details
Copy full SHA for 158fc6a
Browse repository at this point
P0-03: push Phase 0 and record manual environment check
ericmann
committed
9136355
View commit details
Copy full SHA for 9136355
Browse repository at this point
progress: P0-03 done
ericmann
committed
0abe3ad
View commit details
Copy full SHA for 0abe3ad
Browse repository at this point
P1-01: Two_Factor_Secrets adapter and shared secrets test case
Show description for 07e94fb
ericmann
committed
07e94fb
View commit details
Copy full SHA for 07e94fb
Browse repository at this point
progress: P1-01 done
ericmann
committed
ae8d03c
View commit details
Copy full SHA for ae8d03c
Browse repository at this point
P1-02: provider unavailable/uninstall hooks and fail-closed core handling
Show description for 1d74d90
ericmann
committed
1d74d90
View commit details
Copy full SHA for 1d74d90
Browse repository at this point
progress: P1-02 done
ericmann
committed
8d47283
View commit details
Copy full SHA for 8d47283
Browse repository at this point
P1-03: push Phase 1 and record manual check
ericmann
committed
9046c96
View commit details
Copy full SHA for 9046c96
Browse repository at this point
progress: P1-03 done
ericmann
committed
a96cfc7
View commit details
Copy full SHA for a96cfc7
Browse repository at this point
P2-01: TOTP tri-state read, Secrets API writes and lazy migration
Show description for 234dc05
ericmann
committed
234dc05
View commit details
Copy full SHA for 234dc05
Browse repository at this point
progress: P2-01 done
ericmann
committed
ea66afe
View commit details
Copy full SHA for ea66afe
Browse repository at this point
P2-02: fail-closed TOTP validation, prompt, profile UI and lockout regression
Show description for f346ba4
ericmann
committed
f346ba4
View commit details
Copy full SHA for f346ba4
Browse repository at this point
progress: P2-02 done
ericmann
committed
5c2a24c
View commit details
Copy full SHA for 5c2a24c
Browse repository at this point
P2-03: user deletion hooks and uninstall cleanup of Secrets API entries
Show description for ec6277d
ericmann
committed
ec6277d
View commit details
Copy full SHA for ec6277d
Browse repository at this point
progress: P2-03 done
ericmann
committed
f67fb21
View commit details
Copy full SHA for f67fb21
Browse repository at this point
P2-04: push Phase 2 and record manual check
ericmann
committed
04e6053
View commit details
Copy full SHA for 04e6053
Browse repository at this point
progress: P2-04 done
ericmann
committed
f085230
View commit details
Copy full SHA for f085230
Browse repository at this point
P3-01: affected-user detection and administrator notice
Show description for 3613cd1
ericmann
committed
3613cd1
View commit details
Copy full SHA for 3613cd1
Browse repository at this point
progress: P3-01 done
ericmann
committed
fdb1c5f
View commit details
Copy full SHA for fdb1c5f
Browse repository at this point
P3-02: Site Health test two_factor_totp_secret_storage
Show description for 866b1ca
ericmann
committed
866b1ca
View commit details
Copy full SHA for 866b1ca
Browse repository at this point
progress: P3-02 done
ericmann
committed
eca12c4
View commit details
Copy full SHA for eca12c4
Browse repository at this point
P3-03: push Phase 3 and record manual check
ericmann
committed
8eea02d
View commit details
Copy full SHA for 8eea02d
Browse repository at this point
progress: P3-03 done
ericmann
committed
583689a
View commit details
Copy full SHA for 583689a
Browse repository at this point
P4-01: wp two-factor status storage field and secrets status
Show description for 60c5017
ericmann
committed
60c5017
View commit details
Copy full SHA for 60c5017
Browse repository at this point
progress: P4-01 done
ericmann
committed
c047f13
View commit details
Copy full SHA for c047f13
Browse repository at this point
P4-02: wp two-factor secrets migrate
Show description for f5d6fbf
ericmann
committed
f5d6fbf
View commit details
Copy full SHA for f5d6fbf
Browse repository at this point
progress: P4-02 done
ericmann
committed
a3cdb74
View commit details
Copy full SHA for a3cdb74
Browse repository at this point
P4-03: wp two-factor secrets export
Show description for 89affc9
ericmann
committed
89affc9
View commit details
Copy full SHA for 89affc9
Browse repository at this point
progress: P4-03 done
ericmann
committed
f691be8
View commit details
Copy full SHA for f691be8
Browse repository at this point
P4-04: push Phase 4 and record manual check
ericmann
committed
3594837
View commit details
Copy full SHA for 3594837
Browse repository at this point
progress: P4-04 done
ericmann
committed
986385b
View commit details
Copy full SHA for 986385b
Browse repository at this point
P5-01: readme.txt and CHANGELOG.md
Show description for 814fcf8
ericmann
committed
814fcf8
View commit details
Copy full SHA for 814fcf8
Browse repository at this point
progress: P5-01 done
ericmann
committed
8ba2240
View commit details
Copy full SHA for 8ba2240
Browse repository at this point
P5-02: AGENTS.md, TESTS.md and docblock audit
Show description for 0f5d369
ericmann
committed
0f5d369
View commit details
Copy full SHA for 0f5d369
Browse repository at this point
progress: P5-02 done
ericmann
committed
5e73d72
View commit details
Copy full SHA for 5e73d72
Browse repository at this point
P5-03: upstream PR description
Show description for b869510
ericmann
committed
b869510
View commit details
Copy full SHA for b869510
Browse repository at this point
progress: P5-03 done
ericmann
committed
051e1f9
View commit details
Copy full SHA for 051e1f9
Browse repository at this point
P5-04: push Phase 5 and record final manual check
ericmann
committed
b3d571f
View commit details
Copy full SHA for b3d571f
Browse repository at this point
progress: P5-04 done
ericmann
committed
5826028
View commit details
Copy full SHA for 5826028
Browse repository at this point
chore: handoff for review
ericmann
committed
f7618bb
View commit details
Copy full SHA for f7618bb
Browse repository at this point
chore: round 0 implemented
ericmann
committed
9dac25f
View commit details
Copy full SHA for 9dac25f
Browse repository at this point
review: round 1
ericmann
committed
c1e4a90
View commit details
Copy full SHA for c1e4a90
Browse repository at this point
chore: start review-fix round 1
ericmann
committed
c99d5cf
View commit details
Copy full SHA for c99d5cf
Browse repository at this point
R1-01: Correct lockout and decommissioning docs for Secrets API storage
Show description for b6e6c61
ericmann
committed
b6e6c61
View commit details
Copy full SHA for b6e6c61
Browse repository at this point
progress: R1-01 done
ericmann
committed
b8704fa
View commit details
Copy full SHA for b8704fa
Browse repository at this point
chore: handoff for review
ericmann
committed
a006744
View commit details
Copy full SHA for a006744
Browse repository at this point
chore: round 1 implemented
ericmann
committed
70d6209
View commit details
Copy full SHA for 70d6209
Browse repository at this point
review: round 2 approved
ericmann
committed
fe547f2
View commit details
Copy full SHA for fe547f2
Browse repository at this point
chore: build summary
ericmann
committed
f985a3a
View commit details
Copy full SHA for f985a3a
Browse repository at this point
Keep TOTP secret lifecycle hooks when TOTP is disabled site-wide
Show description for 0d52b80
ericmann
committed
0d52b80
View commit details
Copy full SHA for 0d52b80
Browse repository at this point
Update PR description: history, fail-closed rationale, disabled-TOTP fix
ericmann
committed
4118f8d
View commit details
Copy full SHA for 4118f8d
Browse repository at this point
You can’t perform that action at this time.