Fix compiler warnings and NDStdArrays_settings.req $(R) prefix. - #41
Open
AbdallaDalleh wants to merge 1 commit into
Open
Fix compiler warnings and NDStdArrays_settings.req $(R) prefix.#41AbdallaDalleh wants to merge 1 commit into
AbdallaDalleh wants to merge 1 commit into
Conversation
NDStdArrays_settings.req: autosave complains that NDStdArrays
PVs (PREFIX:image1:*) are not found while the template is loaded
with (PREFIX:AH501:) so now autosave will look for
PREFIX:AH501:image1:*
Compiler warnings:
-Wstrict-aliasing : Fixed using memcpy on a temp variable.
-Wunused-but-set-variable : Added extra check if status != asynSuccess
besides (nRead == 0) on calls to pasynOctetSyncIO->read, other
warning locations was "fixed" using (void)variable. Marked TODO
for future references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NDStdArrays_settings.req: autosave complains that NDStdArrays PVs(PREFIX:image1:)are not found while the template is loaded with(PREFIX:AH501:)so now autosave will look forPREFIX:AH501:image1:*Compiler warnings:
-Wstrict-aliasing: Fixed using memcpy on a temp variable.-Wunused-but-set-variable: Added extra checkstatus != asynSuccessbesides(nRead == 0)on calls topasynOctetSyncIO->read, other warning locations was "fixed" using(void)variable. MarkedTODOfor future references.