Repository navigation
service: log Redis errors and report in-flight calls - #1273
Merged
Merged
Conversation
When Redis stopped answering nothing showed it: rate limit calls blocked rather than failing, so redis_error stayed at 0 and the response time histogram recorded nothing because no call completed. When Redis errors did happen, they were only logged at debug level. - Log Redis errors in ShouldRateLimit at warning level, rate-limited to once every 10s with a count of suppressed messages. - Add a call.should_rate_limit.inflight gauge: calls received and not yet answered, which keeps growing while calls are stuck. Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Redis stops answering, nothing is shown: rate-limit calls are blocked rather than failing, so redis_error stays at 0, and the response time histogram records nothing because no call completes. When Redis errors happen, they are only logged at debug level.