Repository navigation
Conversation
Signed-off-by: Tian Mi <tianmi@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
Author
|
/assign @stevenzzzz |
stevenzzzz
reviewed
Nov 3, 2026
stevenzzzz
left a comment
stevenzzzz
left a comment
Contributor
There was a problem hiding this comment.
Pls let Yanjun take a look as well.
Most nits.
Signed-off-by: Tian Mi <tianmi@google.com>
Contributor
Author
|
/assign @yanjunxiang-google |
Signed-off-by: Tian Mi <tianmi@google.com>
… issue Signed-off-by: Tian Mi <tianmi@google.com>
Contributor
|
/assign @yanjunxiang-google |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: fault: add dry_run mode for HTTP fault abort injection
Additional Description:
Add an opt-in
dry_runboolean field toFaultAbortso operators can validate abort matchers and percentages against live traffic without rejecting requests. Whendry_runis true and a request matches the abort fault (either on header evaluation or after a delay timer completes),FaultFilterincrementsaborts_dry_run(including per-downstream-cluster stats) and records configuredfilter_metadataon stream dynamic metadata while omitting theFaultInjectedresponse flag andactive_faultsaccounting so decoding continues normally.Risk Level: Low (opt-in via
FaultAbort.dry_run; no behavior change when unset/false)Testing: Unit tests (
fault_config_test,fault_filter_test) and integration test (fault_filter_integration_test)Docs Changes: Added
FaultAbort.dry_runproto documentation andaborts_dry_run/<downstream-cluster>.aborts_dry_runcounters infault_filter.rstRelease Notes: N/A
Platform Specific Features: N/A