Conversation
sbc100
changed the title
FS.analyzePath and remove internal usagesFS.analyzePath and remove internal usages
sbc100
force-pushed
the
remove_analyzePath_internal
branch
2 times, most recently
from
September 22, 2026 20:27
8376656 to
fda4986
Compare
sbc100
force-pushed
the
remove_analyzePath_internal
branch
from
September 22, 2026 20:36
fda4986 to
0bcc110
Compare
sbc100
force-pushed
the
remove_analyzePath_internal
branch
from
September 22, 2026 20:40
0bcc110 to
1085dab
Compare
hoodmane
reviewed
Sep 22, 2026
sbc100
force-pushed
the
remove_analyzePath_internal
branch
2 times, most recently
from
September 22, 2026 21:48
25bfb05 to
8dc24a5
Compare
Member
|
What is the motivation/background? |
Collaborator
Author
|
Collaborator
Author
|
(added to the PR description) |
sbc100
force-pushed
the
remove_analyzePath_internal
branch
from
September 22, 2026 22:32
8dc24a5 to
076db70
Compare
Replace the remaining internal calls to `FS.analyzePath`: - In `emscripten_run_preload_plugins` (`src/lib/libbrowser.js`), read the file contents directly via `FS.readFile(_file)`. - In `src/lib/liblz4.js` and `src/postamble.js`, use `FS.lookupPath` directly to get the underlying `FSNode`. - Remove the stub `FS.analyzePath` from `src/lib/libwasmfs.js` (which was only added in emscripten-core#19634 for `emscripten_run_preload_plugins`) and drop `_wasmfs_identify` from `REQUIRED_EXPORTS` in `tools/link.py`. Also move `FS.analyzePath` documentation to the legacy v1 compatibility section in `advanced-apis.rst` and emit a `warnOnce` deprecation notice in `ASSERTIONS` builds.
sbc100
force-pushed
the
remove_analyzePath_internal
branch
from
September 22, 2026 22:46
076db70 to
82e8232
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the remaining internal calls to
FS.analyzePath:emscripten_run_preload_plugins(src/lib/libbrowser.js), read the file contents directly viaFS.readFile(_file).src/lib/liblz4.js, useFS.lookupPathdirectly to get the underlyingFSNode.FS.analyzePathfromsrc/lib/libwasmfs.js(which was only added in WasmFS: Get emscripten_run_preload_plugins working #19634 foremscripten_run_preload_plugins) and drop_wasmfs_identifyfromREQUIRED_EXPORTSintools/link.py.Also move
FS.analyzePathdocumentation to the legacy v1 compatibility section inadvanced-apis.rstand emit awarnOncedeprecation notice inASSERTIONSbuilds.Why are we doing this: