Bump google-closure-compiler to 20260831.0.0 - #27689
Open
brendandahl wants to merge 1 commit into
Open
brendandahl wants to merge 1 commit into
brendandahl wants to merge 1 commit into
Conversation
brendandahl
force-pushed
the
update-closure
branch
from
September 9, 2026 18:30
4fc7181 to
33e31d0
Compare
sbc100
reviewed
Sep 14, 2026
| continue | ||
| if arg.startswith('--externs=') and arg.split('=', 1)[1].strip('\'"').endswith('webgpu-externs.js'): | ||
| continue | ||
| filtered.append(arg) |
Collaborator
There was a problem hiding this comment.
Does this need to be this complex? Can't see just assume the exactly form that emdawn uses?
sbc100
reviewed
Sep 14, 2026
|
|
||
| def filter_closure_args(args): | ||
| # TODO: this can be removed once emdawnwebgpu no longer passes in | ||
| # --externs=webgpu-externs.js |
Collaborator
There was a problem hiding this comment.
Please open a bug in emdawn and link it here.
Collaborator
There was a problem hiding this comment.
(here via https://crbug.com/562078433 which Brendan filed)
I think we should update here to skip on emscripten 6.0.10+ or whatever - if there's a way to detect the version - and you can land this without filtering.
Brendan any chance you could try this and send a Dawn CL? (or a PR to https://github.com/google/dawn, that's probably easier)
Update google-closure-compiler dependency to version 20260831.0.0. Remove the WebAssembly.Memory.prototype.toResizableBuffer extern definition, which is now provided natively by Closure Compiler. Update the fixedGetContext return type annotation to RenderingContext to match Closure's updated HTMLCanvasElement getContext extern. Filter out webgpu-externs.js when building with emdawnwebgpu because Closure Compiler now includes native WebGPU externs (w3c_webgpu.js). Rebaseline codesize test expectations for the updated compiler output.
brendandahl
force-pushed
the
update-closure
branch
from
September 15, 2026 18:49
33e31d0 to
915edea
Compare
sbc100
reviewed
Sep 15, 2026
| "a.out.js": 270584, | ||
| "a.out.nodebug.wasm": 588266, | ||
| "total": 858850, | ||
| "a.out.js": 270729, |
Collaborator
There was a problem hiding this comment.
This one is a 250 byte regression... kind of sad :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update google-closure-compiler dependency to version 20260831.0.0.
Remove the WebAssembly.Memory.prototype.toResizableBuffer extern definition, which is now provided natively by Closure Compiler.
Update the fixedGetContext return type annotation to RenderingContext to match Closure's updated HTMLCanvasElement getContext extern.
Rebaseline codesize test expectations for the updated compiler output.