Revert #27397: Use shlex.split for executables in config file - #27421
Open
sbc100 wants to merge 1 commit into
Open
Revert #27397: Use shlex.split for executables in config file#27421sbc100 wants to merge 1 commit into
sbc100 wants to merge 1 commit into
Conversation
…ig file This ended up breaking emsdk in ways that would require more complexity to fix. See emscripten-core/emsdk#1752. This issue is that if emsdk is installed in the path contains spaces the NODE_JS path, for example, then needs to be quoted correctly in the config file. e.g. `NODE_JS = '"path with spaces/bin/node"'. Instead I think we should just revert this change. It turns out not to be needed for emscripten-core#27401 anyway since the LLVM_ROOT is never a list anyway.
sbc100
commented
Jul 27, 2026
| if x is None or type(x) is list: | ||
| return x | ||
| if type(x) is list: | ||
| logger.warning(f'Found list-style config entry ({x}). Please use a single string with spaces between args.') |
Collaborator
Author
There was a problem hiding this comment.
@kripken I know you weren't a fan of adding this warning in the first place so you'll be glad to see this reverted.
Collaborator
Author
|
I'll trigger another release as soon as this lands so that emscripten-core/emsdk#1752 can be fixed. This does mean that 6.0.4 itself will always be broken for emsdk users who install emskd in path with spaces. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ended up breaking emsdk in ways that would require more complexity to fix. See emscripten-core/emsdk#1752.
This issue is that if emsdk is installed in the path contains spaces the NODE_JS path, for example, then needs to be quoted correctly in the config file. e.g. `NODE_JS = '"path with spaces/bin/node"'.
Instead I think we should just revert this change. It turns out not to be needed for #27401 anyway since the LLVM_ROOT is never a list anyway.