Add --skipLibCheck to tsc tests#26767
Open
brendandahl wants to merge 1 commit intoemscripten-core:mainfrom
Open
Add --skipLibCheck to tsc tests#26767brendandahl wants to merge 1 commit intoemscripten-core:mainfrom
brendandahl wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
External type definitions in node_modules can cause errors unrelated to the code being tested. This can happen when running a single test and the node_modules are discovered in a parent directory. Add a helper function to run `tsc` with `--skipLibCheck` and use it in `test_other.py` to avoid these failures.
sbc100
reviewed
Apr 23, 2026
| # Test that the output compiles with a TS file that uses the definitions. | ||
| cmd = shared.get_npm_cmd('tsc') + [test_file('other/test_tsd.ts'), '--noEmit'] | ||
| cmd = self.get_tsc_cmd() + [test_file('other/test_tsd.ts'), '--noEmit'] | ||
| shared.check_call(cmd) |
Collaborator
There was a problem hiding this comment.
Is there a reason we don't use self.run_process here? Maybe combine that into get_tsc_cmd and call it run_tsc?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External type definitions in node_modules can cause errors unrelated to the code being tested. This can happen when running a single test and the node_modules are discovered in a parent directory.
Add a helper function to run
tscwith--skipLibCheckand use it intest_other.pyto avoid these failures.